Output reloading flaky test: Log when test fails #18071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
andresrc
added
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
force-pushed
the
lb-reload-output-log
branch
from
471648c to
f6dd27d
Compare
|
jenkins, test this please |
urso
reviewed
May 14, 2020
| t.Errorf("expected %d traces, got %d", numBatches, len(transactions)) | ||
| } | ||
| } | ||
|
|
||
| type bufLogger struct { |
There was a problem hiding this comment.
why introduce a buffer instead of directly logging to t? In order to minimize noise in test output? In that case maybe add a comment explaining the why.
There was a problem hiding this comment.
Yes, exactly. So we only emit the log entries if the test fails, not if it succeeds. I will add the comment, thanks!
There was a problem hiding this comment.
Done in 96b39e7.
urso
approved these changes
May 15, 2020
ycombinator
added
needs_backport
zube
bot
added
[zube]: Done
and removed
[zube]: In Review
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add logging when output reloading test fails.
Why is it important?
While we made some concurrency fixes to the output reloading code path in #17381, it appears there might still be a race condition somewhere. So far we have only seen this show up occasionally in CI (see test failures captured in #17965) and have not been able to reproduce it locally. So this PR will allow us to see logs of what was happening when the output reloading test fails.
Related issues