-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Fix install service script for windows #18814
Merged
michalpristas
merged 3 commits into
elastic:master
from
michalpristas:agent-fix-install-service
May 29, 2020
Merged
[Ingest Manager] Fix install service script for windows #18814
michalpristas
merged 3 commits into
elastic:master
from
michalpristas:agent-fix-install-service
May 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
bug
review
needs_backport
PR is waiting to be backported to other branches.
Team:Ingest Management
Ingest Management:alpha1
Group issues for ingest management alpha1
labels
May 28, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
May 28, 2020
@andrewkroh Could you take a look at this? |
andrewkroh
approved these changes
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In theory this would work for the Beats too since (IIRC) they actually have run
as their default sub command.
…fix-install-service
ph
approved these changes
May 28, 2020
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 29, 2020
[Ingest Manager] Fix install service script for windows (elastic#18814)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 29, 2020
[Ingest Manager] Fix install service script for windows (elastic#18814)
This was referenced May 29, 2020
michalpristas
added a commit
that referenced
this pull request
May 29, 2020
michalpristas
added a commit
that referenced
this pull request
May 29, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 2, 2020
…-stage-level * upstream/master: (30 commits) Add a GRPC listener service for Agent (elastic#18827) Disable host.* fields by default for iptables module (elastic#18756) [WIP] Clarify capabilities of the Filebeat auditd module (elastic#17068) fix: rename file and remove extra separator (elastic#18881) ci: enable JJBB (elastic#18812) Disable host.* fields by default for Checkpoint module (elastic#18754) Disable host.* fields by default for Cisco module (elastic#18753) Update latest.yml testing env to 7.7.0 (elastic#18535) Upgrade k8s.io/client-go and k8s keystore tests (elastic#18817) Add missing Jenkins stages for Auditbeat (elastic#18835) [Elastic Log Driver] Create a config shim between libbeat and the user (elastic#18605) Use indexers and matchers in config when defaults are enabled (elastic#18818) Fix panic on `metricbeat test modules` (elastic#18797) [CI] Fix permissions in MacOSX agents (elastic#18847) [Ingest Manager] When not port are specified and the https is used fallback to 443 (elastic#18844) [Ingest Manager] Fix install service script for windows (elastic#18814) [Metricbeat] Fix getting compute instance metadata with partial zone/region config (elastic#18757) Improve error messages in s3 input (elastic#18824) Add memory metrics into compute googlecloud (elastic#18802) include bucket name when logging error (elastic#18679) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Ingest Management:alpha1
Group issues for ingest management alpha1
needs_backport
PR is waiting to be backported to other branches.
review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Agent was using beat version of install service script for windows but the way how agent is started is different.
This PR aligns script with the agent command syntax
Why is it important?
To enable agent be installed on windows as a service
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Fixes: #18811