Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18814 to 7.x: Fix install service script for windows #18842

Merged
merged 1 commit into from
May 29, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #18814 to 7.x branch. Original message:

What does this PR do?

Agent was using beat version of install service script for windows but the way how agent is started is different.
This PR aligns script with the agent command syntax

Why is it important?

To enable agent be installed on windows as a service

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #18811

[Ingest Manager] Fix install service script for windows (elastic#18814)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 29, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Michal Pristas, Replayed #1]

  • Start Time: 2020-05-29T11:24:06.221+0000

  • Duration: 78 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 6648
Skipped 1053
Total 7701

@michalpristas michalpristas merged commit 08eb270 into elastic:7.x May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Ingest Management:alpha1 Group issues for ingest management alpha1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants