Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The '-c' flag can be used multiple times #1985

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Conversation

urso
Copy link

@urso urso commented Jul 7, 2016

Change '-c' flag to load and merge all config files given on command line via
'-c' flag.

@urso
Copy link
Author

urso commented Jul 7, 2016

blocked by #1984

@urso urso force-pushed the enh/config-flags branch 2 times, most recently from 1f59107 to db20a53 Compare July 7, 2016 12:24
@urso urso force-pushed the enh/config-flags branch from db20a53 to aa0c2d9 Compare July 8, 2016 10:01
@urso urso removed the blocked label Jul 8, 2016
@tsg
Copy link
Contributor

tsg commented Jul 8, 2016

LGTM. Does the order matter. i.e. options from the second file overwrite the options from the first file? I'm curious what use case you have in mind with this.

@urso
Copy link
Author

urso commented Jul 8, 2016

Yes, order does matter. The second file will overwrite options from first file.
I'd like to have this mostly for manual testing releases overwriting configs (e.g. libbeat based) without having to change every single config file. Instead of modifying the configs every so often when testing, this allows me to prepare configurations with outputs and special hosts I want to test with.

This might also make sense in production when running multiple beats, as output configurations can be shared in one config file only.

This PR + #1986 add some additional flexibility for overwriting configs.

Change '-c' flag to load and merge all config files given on command line via
'-c' flag.
@urso urso force-pushed the enh/config-flags branch from aa0c2d9 to 87ea4e5 Compare July 8, 2016 13:54
@tsg tsg merged commit a32eb74 into elastic:master Jul 8, 2016
@urso urso deleted the enh/config-flags branch February 19, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants