Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable-setting to all output plugins #1987

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

urso
Copy link

@urso urso commented Jul 7, 2016

No description provided.

@urso urso added review blocked in progress Pull request is currently in progress. and removed blocked review labels Jul 7, 2016
@urso urso force-pushed the enh/outputs-enabled-setting branch 2 times, most recently from 810d148 to 4da8872 Compare July 7, 2016 13:26
@urso urso added review and removed in progress Pull request is currently in progress. labels Jul 7, 2016
@urso urso force-pushed the enh/outputs-enabled-setting branch from 4da8872 to 698259b Compare July 7, 2016 15:28
@monicasarbu
Copy link
Contributor

Shall we also update thefull configuration files of the Beats to contain enable even if it's not needed?

@urso
Copy link
Author

urso commented Jul 7, 2016

Not sure. For me the enable-config mostly makes sense in conjunction with #1985 and #1986, as this will allow to disable modules e.g. from command line.

But having it named full-config, maybe it makes sense to add enable.

@tsg
Copy link
Contributor

tsg commented Jul 8, 2016

I think it should be in the full configs, as we said the full configs contain all the non-deprecated options and they can be used as a reference.

@monicasarbu
Copy link
Contributor

As you already added the enable option, I would say to use it in the full -config as it's easier to just change the value of enable instead of commenting in/out an output.

@monicasarbu
Copy link
Contributor

+1 enable/disable one output in the command line.

@urso
Copy link
Author

urso commented Jul 8, 2016

makes sense. will add enable to full config.

@urso urso force-pushed the enh/outputs-enabled-setting branch from 698259b to e031ef7 Compare July 8, 2016 10:30
@andrewkroh
Copy link
Member

LGTM

@andrewkroh andrewkroh merged commit 4ef2be7 into elastic:master Jul 8, 2016
@ruflin
Copy link
Member

ruflin commented Jul 8, 2016

@urso there is one issue with this PR. Metricbeat uses enabled, you used enable. We should be consistent here.

@urso urso deleted the enh/outputs-enabled-setting branch February 19, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants