libbeat/publisher/pipeline: fix Client.Close #19864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the "closing" variable to true, not false, upon signalling the waiter to close.
axw
added
bug
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
andresrc
added
[zube]: Inbox
needs_team
botelastic
bot
removed
the
needs_team
andresrc
added
[zube]: In Review
needs_team
botelastic
bot
removed
the
needs_team
urso
approved these changes
Jul 21, 2020
2 tasks
2 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Set the "closing" variable to true, not false, upon signalling the waiter to close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a regression in
clientCloseWaiter, so that when aWaitClosetimeout is specified it can be interrupted by all events being acknowledged. Set the "closing" variable to true, not false, upon signalling the waiter to close.Why is it important?
Fixes a regression in
WaitClosebehaviour.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
go test ./libbeat/publisher/pipelineRelated issues
#19514