-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #19864 to 7.9: libbeat/publisher/pipeline: fix Client.Close #20125
Conversation
Set the "closing" variable to true, not false, upon signalling the waiter to close. (cherry picked from commit e7b42d8)
Pinging @elastic/integrations-services (Team:Services) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
CI failures are unrelated and will be investigated separately. Feel free to merge. |
Set the "closing" variable to true, not false, upon signalling the waiter to close. (cherry picked from commit e7b42d8)
Cherry-pick of PR #19864 to 7.9 branch. Original message:
What does this PR do?
Fix a regression in
clientCloseWaiter
, so that when aWaitClose
timeout is specified it can be interrupted by all events being acknowledged. Set the "closing" variable to true, not false, upon signalling the waiter to close.Why is it important?
Fixes a regression in
WaitClose
behaviour.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
go test ./libbeat/publisher/pipeline
Related issues
#19514