-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system/socket: Allow running multiple instances by grouping kprobes by PID #20325
Conversation
This updates the system/socket dataset to group installed kprobes by PID instead of using a generic `auditbeat` group. This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes.
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if there is an easy way (or is worth it) to have an integration test for this though? mostly to prevent a regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! No more conflicts.
…ne-2.0 * upstream/master: [Elastic Agent] Add skeleton for client/server for agent control protocol (elastic#20163) Auditbeat: Allow multiple instances by grouping kprobes by PID (elastic#20325) [Filebeat][Fortinet] Remove pre populated event.timezone (elastic#20273)
…allation * upstream/master: Check expand_event_list_from_field when json in map[string]interface{} format (elastic#20370) [docs] Remove deprecated security roles (elastic#20162) Modify doc in app_insights metricset (elastic#20185) [Elastic Agent] Add skeleton for client/server for agent control protocol (elastic#20163) Auditbeat: Allow multiple instances by grouping kprobes by PID (elastic#20325) [Filebeat][Fortinet] Remove pre populated event.timezone (elastic#20273) Add an explicit system test for processes on unix systems (elastic#20320)
…ic#20325) This updates the system/socket dataset to group installed kprobes by PID instead of using a generic `auditbeat` group. This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes.
…ic#20325) (elastic#20354) This updates the system/socket dataset to group installed kprobes by PID instead of using a generic `auditbeat` group. This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes. (cherry picked from commit 30de776)
…ic#20325) (elastic#20355) This updates the system/socket dataset to group installed kprobes by PID instead of using a generic `auditbeat` group. This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes. (cherry picked from commit 30de776)
What does this PR do?
This updates the system/socket dataset to group installed kprobes by PID instead of using a generic
auditbeat
group.This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes.
Why is it important?
Currently is not possible to run more than one Auditbeat instance under Linux due to kprobes colliding.
Checklist
I've tested this in Ubuntu 18.04 / kernel 4.15 and it can run multiple instances without trouble.
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Closes #20303