Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20325 to 7.9: system/socket: Allow running multiple instances by grouping kprobes by PID #20354

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jul 30, 2020

Cherry-pick of PR #20325 to 7.9 branch. Original message:

What does this PR do?

This updates the system/socket dataset to group installed kprobes by PID instead of using a generic auditbeat group.

This allows multiple instances of Auditbeat to run with the system/socket dataset enabled (default) avoiding collision of kprobes.

Why is it important?

Currently is not possible to run more than one Auditbeat instance under Linux due to kprobes colliding.

Checklist

I've tested this in Ubuntu 18.04 / kernel 4.15 and it can run multiple instances without trouble.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #20303

…ic#20325)

This updates the system/socket dataset to group installed kprobes by
PID instead of using a generic `auditbeat` group.

This allows multiple instances of Auditbeat to run with the
system/socket dataset enabled (default) avoiding collision of kprobes.

(cherry picked from commit 2abf87f)
@adriansr adriansr requested a review from a team as a code owner July 30, 2020 14:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20354 opened]

  • Start Time: 2020-07-30T14:38:56.082+0000

  • Duration: 50 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 230
Skipped 49
Total 279

@adriansr adriansr merged commit 3e9fa6b into elastic:7.9 Jul 31, 2020
@zube zube bot removed the [zube]: Done label Oct 30, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ic#20325) (elastic#20354)

This updates the system/socket dataset to group installed kprobes by
PID instead of using a generic `auditbeat` group.

This allows multiple instances of Auditbeat to run with the
system/socket dataset enabled (default) avoiding collision of kprobes.

(cherry picked from commit 30de776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants