-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Event String Selector #2087
Conversation
737b1c5
to
2c6986e
Compare
blocked by required bug-fixes in go-ucfg: elastic/go-ucfg#46 , elastic/go-ucfg#47, elastic/go-ucfg#48 |
a4fee00
to
d37ab01
Compare
All blockers have been merged. Ready for review. |
LGTM |
func buildSingle(cfg *common.Config, key string) (selector, error) { | ||
// TODO: check for unknown fields | ||
|
||
// 3. extract required key-word handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the numbering here? Is this supposed to be 1.
?
Merged like this, in case the comment above is wrong, it can be easily fixed in a future PR. |
preparing for #2064, implement documented logic for customizable keys.
Differs from #2064 that a single-keyword and a multi-keyword can be configured. If both given, the single-keywork is used as default (last selector in list) if all others do fail.
e.g.
will be equivalen to:
On the other hand:
is syntactic sugar for
Being generic, functionality is re-usable for es-index, logstash-index, redis-key, kafka-topic and others.