Fix unpacking configs into slices #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #45 |
| if to == nil || (vTo.Kind() != reflect.Ptr && vTo.Kind() != reflect.Map) { | ||
|
|
||
| k := vTo.Kind() | ||
| isValid := to != nil && (k == reflect.Ptr || k == reflect.Map) |
There was a problem hiding this comment.
That lines is quite hard to read
There was a problem hiding this comment.
I think it's easier to read then before. it says: to must not be nil and must be either a pointer or a map
|
LGTM |
Fix unpacking into top-level slice/array or unpacking into slice if `inline`-tag is used.
urso
force-pushed
the
fix/45-unpack-into-slice
branch
from
8ea6526 to
d7456e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unpacking into top-level slice/array or unpacking into slice if
inline-tag is used.