[Metricbeat] Add Couchbase's Sync Gateway module #25599

sayden · 2021-05-06T16:56:03Z

WIP

What does this PR do?

This PR adds a Metricset for Sync Gateway https://docs.couchbase.com/sync-gateway/2.7/introduction.html Edge Computing in Couchbase

Why is it important?

Couchbase users can rely on some features provided by the Sync Gateway to sync Couchbase Lite and Servers. This Metricset allows detailed monitorization of the Sync Gateways services.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

elasticmachine · 2021-05-06T17:00:10Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #25599 updated
Start Time: 2021-06-24T15:38:45.682+0000
Duration: 103 min 57 sec
Commit: 5865aa9

Test stats 🧪

Test	Results
Failed	0
Passed	8700
Skipped	2517
Total	11217

Trends 🧪

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	8700
Skipped	2517
Total	11217

…base/syncgateway-metricset

metricbeat/module/couchbase/syncgateway/_meta/docs.asciidoc

kaiyan-sheng

I see this is still a draft PR but just in case the config is forgotten 😬 I think we are missing the config.yml file here :)

elasticmachine · 2021-06-02T17:15:21Z

Pinging @elastic/integrations-services (Team:Services)

sayden · 2021-06-02T17:22:38Z

Okay so I moved everything to a new module 🙂

sayden · 2021-06-02T17:23:26Z

/test

metricbeat/module/syncgateway/db/_meta/fields.yml

metricbeat/module/syncgateway/_meta/config.yml

kaiyan-sheng · 2021-06-04T23:02:12Z

metricbeat/module/syncgateway/db/data_test.go

+	mbtest "github.com/elastic/beats/v7/metricbeat/mb/testing"
+)
+
+func TestData(t *testing.T) {


Is there any way to add TestMetricsetFieldsDocumented somewhere for this module? For example: https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/azure/compute_vm/compute_vm_integration_test.go#L31

Cool! I added them all but in db metricset as it seems there's some bug in the testing script where it doesn't recognize some fields as being documented even when they are there (I checked like.... 10 times 😅 )

I'll take a look at the script once I finish with few things.

metricbeat/module/syncgateway/syncgateway.go

…base/syncgateway-metricset

x-pack/metricbeat/module/syncgateway/_meta/fields.yml

x-pack/metricbeat/module/syncgateway/_meta/testdata/expvar.282c.json

kaiyan-sheng · 2021-06-23T17:03:37Z

x-pack/metricbeat/module/syncgateway/replication/_meta/fields.yml

+  type: group
+  description: >
+    SyncGateway per replication metrics.
+  release: ga


straight to GA?

kaiyan-sheng

Looks good to me besides my concern on going GA straight for this module. WDYT? I will approve the PR and let you decide if you want to go GA or Beat :)

sayden · 2021-06-24T15:38:31Z

Looks good to me besides my concern on going GA straight for this module. WDYT? I will approve the PR and let you decide if you want to go GA or Beat :)

I didn't realized that the metricsets appear as GA too (instead of beta). Thank you! I changed them all

(cherry picked from commit 77eb466)

…arwin-arm64 * upstream/master: (295 commits) Update urllib to 1.26.5. (elastic#26380) Update golang.org/x/crypto (elastic#26448) [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816) Move parsers outside of filestream input so others can use them as well (elastic#26541) [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508) [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620) Logging code cleanup related to Nomad auto-discovery (elastic#26498) [Metricbeat] Add Couchbase's Sync Gateway module (elastic#25599) Refactor add_cloud_metadata to handle ECS fields easier (elastic#26438) [Elastic Agent] Improper casting of int64 (elastic#26520) [Elastic Agent] Enable configuring monitoring namespace (elastic#26439) [Heartbeat] configure permissions for synthetics config (elastic#26393) Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545) [Heartbeat] add screenshots config to synthetics (elastic#26455) [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474) Remove all docs about Beats central management (elastic#26399) update data.json for gcp billing (elastic#26506) Skip x-pack metricbeat tests (elastic#26537) [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529) Add changelog entry for elastic#26224 (elastic#26531) ...

(cherry picked from commit 77eb466)

…module (#27155) * [Metricbeat] Add Couchbase's Sync Gateway module (#25599) (cherry picked from commit 77eb466) * rerun mage update Co-authored-by: Mario Castro <mariocaster@gmail.com>

Atomic commit

c0e778d

sayden added enhancement Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team labels May 6, 2021

sayden self-assigned this May 6, 2021

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 6, 2021

Rewrite data.json

93c22da

sayden mentioned this pull request May 6, 2021

[Metricbeat] Support Couchbase SyncGateway elastic/integrations#818

Closed

sayden added 5 commits May 25, 2021 17:39

Add known fields to fields.yml

7472b37

make update

c42d6c2

Linting plus more update

45632e5

Add docs and some example events

ffc37fe

Merge commit 'a2737b10a61babbfb6882a1953100f6b4021b3ee' into mb/couch…

313a729

…base/syncgateway-metricset

sayden added 7.14 Candidate backport-v7.14.0 Automated backport with mergify labels May 28, 2021

kaiyan-sheng reviewed May 28, 2021

View reviewed changes

metricbeat/module/couchbase/syncgateway/_meta/docs.asciidoc Outdated Show resolved Hide resolved

kaiyan-sheng reviewed May 28, 2021

View reviewed changes

metricbeat/module/couchbase/syncgateway/_meta/docs.asciidoc Outdated Show resolved Hide resolved

kaiyan-sheng reviewed May 28, 2021

View reviewed changes

metricbeat/module/couchbase/syncgateway/_meta/docs.asciidoc Outdated Show resolved Hide resolved

kaiyan-sheng reviewed May 28, 2021

View reviewed changes

sayden added 4 commits May 31, 2021 17:09

Move everything to its own module

98bdbc7

Atomic commit on module

5e67ed5

Final touches

825c00c

Update docs

504d52c

sayden marked this pull request as ready for review June 2, 2021 17:15

sayden changed the title ~~[Metricbeat] Add Sync Gateway Metricset to Couchbase module~~ [Metricbeat] Add Couchbase's Sync Gateway module Jun 2, 2021

mage fmt update on xpack folder

a4cf98f

kaiyan-sheng reviewed Jun 4, 2021

View reviewed changes

metricbeat/module/syncgateway/db/_meta/fields.yml Outdated Show resolved Hide resolved

kaiyan-sheng reviewed Jun 4, 2021

View reviewed changes

metricbeat/module/syncgateway/_meta/config.yml Outdated Show resolved Hide resolved

kaiyan-sheng reviewed Jun 4, 2021

View reviewed changes

metricbeat/module/syncgateway/syncgateway.go Outdated Show resolved Hide resolved

sayden added 6 commits June 14, 2021 15:29

Move module to xpack

b3b35f3

Fix imports

239d93c

Linting and update

ac4eaeb

Merge commit '87994f47ac34c6e6a9a075c62900b2a6d7d1c6c2' into mb/couch…

790cef1

…base/syncgateway-metricset

Update docs

3fb13b4

Add missing test... and skip it

40801a1

kaiyan-sheng reviewed Jun 21, 2021

View reviewed changes

x-pack/metricbeat/module/syncgateway/_meta/fields.yml Outdated Show resolved Hide resolved

kaiyan-sheng reviewed Jun 21, 2021

View reviewed changes

x-pack/metricbeat/module/syncgateway/_meta/testdata/expvar.282c.json Show resolved Hide resolved

Small fixes

4395860

kaiyan-sheng reviewed Jun 23, 2021

View reviewed changes

kaiyan-sheng approved these changes Jun 23, 2021

View reviewed changes

Release metricsets as beta too

5865aa9

sayden merged commit 77eb466 into elastic:master Jun 29, 2021

mergify bot pushed a commit that referenced this pull request Jun 29, 2021

[Metricbeat] Add Couchbase's Sync Gateway module (#25599)

51f6390

(cherry picked from commit 77eb466)

mergify bot mentioned this pull request Jun 29, 2021

[7.x](backport #25599) [Metricbeat] Add Couchbase's Sync Gateway module #26558

Closed

kaiyan-sheng mentioned this pull request Jul 30, 2021

Cherry-pick #25599 to 7.x: [Metricbeat] Add Couchbase's Sync Gateway module #27155

Merged

6 tasks

kaiyan-sheng added the v7.15.0 label Jul 30, 2021

mergify bot pushed a commit that referenced this pull request Jul 30, 2021

[Metricbeat] Add Couchbase's Sync Gateway module (#25599)

d87cc8e

(cherry picked from commit 77eb466)

mergify bot mentioned this pull request Jul 30, 2021

[7.14](backport #25599) [Metricbeat] Add Couchbase's Sync Gateway module #27156

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metricbeat] Add Couchbase's Sync Gateway module #25599

[Metricbeat] Add Couchbase's Sync Gateway module #25599

sayden commented May 6, 2021 •

edited

Loading

elasticmachine commented May 6, 2021 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

Trends 🧪

Test stats 🧪

kaiyan-sheng left a comment

elasticmachine commented Jun 2, 2021

sayden commented Jun 2, 2021 •

edited

Loading

sayden commented Jun 2, 2021

kaiyan-sheng Jun 4, 2021

sayden Jun 23, 2021

kaiyan-sheng Jun 23, 2021

kaiyan-sheng left a comment

sayden commented Jun 24, 2021

[Metricbeat] Add Couchbase's Sync Gateway module #25599

[Metricbeat] Add Couchbase's Sync Gateway module #25599

Conversation

sayden commented May 6, 2021 • edited Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

elasticmachine commented May 6, 2021 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

💚 Flaky test report

Test stats 🧪

kaiyan-sheng left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 2, 2021

sayden commented Jun 2, 2021 • edited Loading

sayden commented Jun 2, 2021

kaiyan-sheng Jun 4, 2021

Choose a reason for hiding this comment

sayden Jun 23, 2021

Choose a reason for hiding this comment

kaiyan-sheng Jun 23, 2021

Choose a reason for hiding this comment

kaiyan-sheng left a comment

Choose a reason for hiding this comment

sayden commented Jun 24, 2021

sayden commented May 6, 2021 •

edited

Loading

elasticmachine commented May 6, 2021 •

edited by jenkins-beats-ci bot

Loading

sayden commented Jun 2, 2021 •

edited

Loading