Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] configure permissions for synthetics config #26393

Merged
merged 4 commits into from
Jun 29, 2021
Merged

[Heartbeat] configure permissions for synthetics config #26393

merged 4 commits into from
Jun 29, 2021

Conversation

vigneshshanmugam
Copy link
Member

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 21, 2021
@vigneshshanmugam vigneshshanmugam added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0 labels Jun 21, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

andrewvc
andrewvc approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing locally, manually

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 21, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: andrewvc commented: /test

  • Start Time: 2021-06-28T21:32:51.535+0000

  • Duration: 153 min 37 sec

  • Commit: a975846

Test stats 🧪

Test Results
Failed 0
Passed 29481
Skipped 3839
Total 33320

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 29481
Skipped 3839
Total 33320

@vigneshshanmugam
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2021

Command update: success

Branch has been successfully updated

@andrewvc
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2021

Command update: success

Branch has been successfully updated

@jsoriano
Copy link
Member

/test

3 similar comments
@jsoriano
Copy link
Member

/test

@jsoriano
Copy link
Member

/test

@vigneshshanmugam
Copy link
Member Author

/test

@vigneshshanmugam
Copy link
Member Author

@mdelapenya E2E tests seem to fail all the time for this PR, Any idea why?

@mdelapenya
Copy link
Contributor

@mdelapenya E2E tests seem to fail all the time for this PR, Any idea why?

@vigneshshanmugam will take a look tomorrow morning. It seems the pipeline is not priority formed. Thanks for pinging me here

@andrewvc
Copy link
Contributor

/test

@mdelapenya
Copy link
Contributor

@vigneshshanmugam we solved an issue when passing the BEAT_VERSION to the e2e tests here: #26469

The existing 3 errors in the e2e are already present in master and 7.x branches, and we are investigating them.

@andrewvc
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2021

Command update: success

Branch has been successfully updated

@urso
Copy link

urso commented Jun 28, 2021

Hm, only packaging of the docker image was updated. All these tests that are run here don't depend on packaging at all.

@urso
Copy link

urso commented Jun 28, 2021

/package

@andrewvc
Copy link
Contributor

/test

@andrewvc andrewvc added the bug label Jun 28, 2021
@urso
Copy link

urso commented Jun 29, 2021

Packaging went fine and PR can be merged without conflicts. I will merge it now, so we have it in.

@urso urso merged commit 591fc3a into elastic:master Jun 29, 2021
@andrewvc
Copy link
Contributor

@Mergifyio backport 7.x

mergify bot pushed a commit that referenced this pull request Jun 29, 2021
@vigneshshanmugam
[Heartbeat] configure permissions for synthetics config (#26393)
edc8fec 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 591fc3a)
@mergify mergify bot mentioned this pull request Jun 29, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2021

Command backport 7.x: success

Backports have been created

v1v added a commit to v1v/beats that referenced this pull request Jun 29, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-d…
2c9f25c 
…arwin-arm64

* upstream/master: (295 commits)
  Update urllib to 1.26.5. (elastic#26380)
  Update golang.org/x/crypto (elastic#26448)
  [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816)
  Move parsers outside of filestream input so others can use them as well (elastic#26541)
  [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508)
  [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620)
  Logging code cleanup related to Nomad auto-discovery (elastic#26498)
  [Metricbeat] Add Couchbase's Sync Gateway module (elastic#25599)
  Refactor add_cloud_metadata to handle ECS fields easier (elastic#26438)
  [Elastic Agent] Improper casting of int64 (elastic#26520)
  [Elastic Agent] Enable configuring monitoring namespace (elastic#26439)
  [Heartbeat] configure permissions for synthetics config (elastic#26393)
  Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545)
  [Heartbeat] add screenshots config to synthetics (elastic#26455)
  [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474)
  Remove all docs about  Beats central management (elastic#26399)
  update data.json for gcp billing (elastic#26506)
  Skip x-pack metricbeat tests (elastic#26537)
  [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529)
  Add changelog entry for  elastic#26224 (elastic#26531)
  ...
vigneshshanmugam added a commit that referenced this pull request Jun 30, 2021
@mergify @vigneshshanmugam
[Heartbeat] configure permissions for synthetics config (#26393) (#26567
2118984 
)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 591fc3a)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
@vigneshshanmugam vigneshshanmugam deleted the add-config-folder branch July 14, 2021 15:39
@vigneshshanmugam vigneshshanmugam mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current Heartbeat/Synthetics Docker image (snapshot) not working
6 participants
@vigneshshanmugam @elasticmachine @andrewvc @jsoriano @mdelapenya @urso