-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move backwards compatible flag manipulation #41136
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to just before flag.Parse. Having in init conflicted with using libbeat in other apps that have their own flag parsing.
leehinman
added
bug
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
backport-8.x
Automated backport to the 8.x branch with mergify
labels
Oct 4, 2024
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 4, 2024
blakerouse
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is there a way for us to add a test for this? |
ycombinator
approved these changes
Oct 4, 2024
Yes. I just wanted to the the tests started |
This was referenced Oct 4, 2024
VihasMakwana
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
bug
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
libbeat manipulates the command line arguments to support older single dash arguments, for example
-e
vs--e
.Currently this is done in an init function.
Doing it there means that if libbeat is imported into another code base with it's own command line parsing it will cause things like
-1s
to be interpreted as--1s
instead of negative 1 second.This PR moves the manipulation of the command line arguments to just before the call to
flag.Parse()
.This allows other code bases to import libbeat and not be affected by the backwards compatibility manipulation.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs