Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Don't register cfgfile flags on flag.CommandLine in func init()" #41152

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Revert "Don't register cfgfile flags on flag.CommandLine in func init()" #41152

merged 4 commits into from
Oct 7, 2024

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman requested a review from a team as a code owner October 7, 2024 16:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2024
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 7, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2024
@leehinman leehinman added needs_team Indicates that the issue/PR needs a Team:* label backport-8.x Automated backport to the 8.x branch with mergify labels Oct 7, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2024
@leehinman leehinman requested a review from cmacknz October 7, 2024 16:01
@leehinman leehinman mentioned this pull request Oct 7, 2024
Open
@jlind23 jlind23 enabled auto-merge (squash) October 7, 2024 16:43
@leehinman leehinman mentioned this pull request Oct 7, 2024
Closed
6 tasks
@jlind23 jlind23 merged commit 2ff38df into main Oct 7, 2024
141 checks passed
@jlind23 jlind23 deleted the revert-40993-cfgfile-flags-import branch October 7, 2024 20:16
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@leehinman @mergify
Revert "Don't register cfgfile flags on flag.CommandLine in `func i…
d7c6474 
…nit()`" (#41152)

* Revert "Don't register cfgfile flags on `flag.CommandLine` in `func init()` (…"

This reverts commit 07360ca.

* linter fixes

(cherry picked from commit 2ff38df)
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
leehinman added a commit that referenced this pull request Oct 7, 2024
@mergify @leehinman
Revert "Don't register cfgfile flags on flag.CommandLine in `func i…
67bbb70 
…nit()`" (#41152) (#41161)

* Revert "Don't register cfgfile flags on `flag.CommandLine` in `func init()` (…"

This reverts commit 07360ca.

* linter fixes

(cherry picked from commit 2ff38df)

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
@carsonip carsonip mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@carsonip carsonip carsonip approved these changes

@jlind23 jlind23 jlind23 approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees

@leehinman leehinman

Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leehinman @elasticmachine @AndersonQ @carsonip @jlind23