[8.x](backport #41108) Fix cgroup helper init in add_processor_metadata and add_docker_metadata processors
#41185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
faec and
leehinman
and removed request for
a team
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
pierrehilbert
approved these changes
Oct 9, 2024
|
This requires #41196 at the same time or it will break non-Linux systems when it merges, perhaps best to combine the two backports. |
|
Three backports if you also want to include #41198 when that merges. |
|
Alright, lets see if I can merge these two PRs without blowing things up.... |
* add tests, fallback properly if we can't init the cgroups * linter * fix test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Closes #41065
This refactors
add_processor_metadataandadd_docker_metadataso we only callNewReaderonce when we create a new processor, and not every time the processor runs. This should considerably cut down on CPU cycles for certain workloads, sinceNewReaderhas gotten much more complex over the years.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.This is an automatic backport of pull request #41108 done by [Mergify](https://mergify.com).