-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nil cgroups reader for processor, improve error handling #41198
Create nil cgroups reader for processor, improve error handling #41198
Conversation
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
* create nil reader, improve error handling * add test, clean up * linter (cherry picked from commit 764ba96) # Conflicts: # filebeat/autodiscover/defaults_aix.go # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go
* create nil reader, improve error handling * add test, clean up * linter
…ve error handling (#41205) * Create nil cgroups reader for processor, improve error handling (#41198) * create nil reader, improve error handling * add test, clean up * linter (cherry picked from commit 764ba96) # Conflicts: # filebeat/autodiscover/defaults_aix.go # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go * Revert "Create nil cgroups reader for processor, improve error handling (#41198)" This reverts commit 0b886fc. * Create nil cgroups reader for processor, improve error handling (#41198) * create nil reader, improve error handling * add test, clean up * linter --------- Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com> Co-authored-by: fearful-symmetry <alexpkristiansen@icloud.com>
Proposed commit message
Continuation of #41189 . This adds a
NilCGReader
type that makes us a little less likely to hit a nil pointer deref if this code is changed in the future, and also cleans up some of the error handling.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.