-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #41198) Create nil cgroups reader for processor, improve error handling #41205
Conversation
* create nil reader, improve error handling * add test, clean up * linter (cherry picked from commit 764ba96) # Conflicts: # filebeat/autodiscover/defaults_aix.go # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go
Cherry-pick of 764ba96 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request doesn't have a |
@fearful-symmetry could you please fix the conflicts here? |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏 |
* create nil reader, improve error handling * add test, clean up * linter
Proposed commit message
Continuation of #41189 . This adds a
NilCGReader
type that makes us a little less likely to hit a nil pointer deref if this code is changed in the future, and also cleans up some of the error handling.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.This is an automatic backport of pull request #41198 done by [Mergify](https://mergify.com).