-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cms_get and cmd_set mixed up in memcached module #5189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just created this here and thought to look at the code. https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732
Can one of the admins verify this patch? |
tsg
approved these changes
Sep 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for noticing that! Can you add a line to the CHANGELOG, under Bug Fixes please? Something like Fixed cmd_set/cmd_get being mixed up in the memcached module {pull}5189[5189]
Merging, will add changelog in a new PR. |
tsg
added a commit
to tsg/beats
that referenced
this pull request
Sep 25, 2017
ruflin
pushed a commit
that referenced
this pull request
Sep 25, 2017
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Sep 25, 2017
I just created this here and thought to look at the code. https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732 (cherry picked from commit f1bc714)
tsg
added a commit
to tsg/beats
that referenced
this pull request
Sep 25, 2017
(cherry picked from commit 829f833)
ruflin
pushed a commit
that referenced
this pull request
Sep 25, 2017
…odule (#5233) Cherry-pick of PR #5189 to 6.0 branch. Original message: I just created this here and thought to look at the code. https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ached module (elastic#5233) Cherry-pick of PR elastic#5189 to 6.0 branch. Original message: I just created this here and thought to look at the code. https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just created this here and thought to look at the code.
https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732