Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5189 to 6.0: cms_get and cmd_set mixed up in memcached module #5233

Merged
merged 3 commits into from
Sep 25, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Sep 25, 2017

Cherry-pick of PR #5189 to 6.0 branch. Original message:

I just created this here and thought to look at the code.

https://discuss.elastic.co/t/metricbeat-memcached-module-seems-to-mix-up-memcached-stats-cmd-get-and-memcached-stats-cmd-set/100732

@tsg tsg added the v6.0.0-rc2 label Sep 25, 2017
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, I don't think failures are related? Should it be squashed into 1 commit?

@tsg
Copy link
Contributor Author

tsg commented Sep 25, 2017

Yeah, please squash. Thanks.

@ruflin ruflin merged commit 7df2772 into elastic:6.0 Sep 25, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants