-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update running-on-docker.asciidoc #6385
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@dedemorton - A question about the asciidoc callouts and trailing spaces -- If you copy and paste the Do you know if there is anything we can change to make the trailing spaces go away? The trailing spaces break the ability to directly paste the command to the CLI. |
@andrewkroh AFAIK, the extra whitespace is a side effect of having a callout. I'm going to follow up with our docs infra person because I think it would be great to have some kind of Copy Command functionality in the docs. Thanks for bringing this up. |
@@ -19,7 +19,7 @@ docker run \ | |||
--volume=/sys/fs/cgroup:/hostfs/sys/fs/cgroup:ro \ <2> | |||
--volume=/:/hostfs:ro \ <3> | |||
--net=host <4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs a trailing backslash for line continuation. Should be: --net=host \ <4>
* Update running-on-docker.asciidoc -e option was missing See https://discuss.elastic.co/t/running-metricbeat-in-docker-and-monitoring-the-host-system-does-not-work-with-command-from-documentation/119821 * Add missing backslash
-e option was missing
See https://discuss.elastic.co/t/running-metricbeat-in-docker-and-monitoring-the-host-system-does-not-work-with-command-from-documentation/119821