Add Filebeat modules to packages #7487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 3, 2018
dev-tools/mage/copy.go
Outdated
| excludes []*regexp.Regexp // Compiled exclude regexes. | ||
| } | ||
|
|
||
| func (t *CopyTask) Execute() error { |
There was a problem hiding this comment.
exported method CopyTask.Execute should have comment or be unexported
This adds the Filebeat modules files to packages. They were missed during the refactor. It also fixes a minor issue where files were not marked as config within .rpm files.
andrewkroh
force-pushed
the
bugfix/package-filebeat-modules
branch
from
0262909 to
047c92d
Compare
|
Code LGTM. Have not tested it locally but we should after the packaging job did run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Filebeat modules files to packages. They were missed during the refactor.
It also fixes a minor issue where files were not marked as config within .rpm files.
I opened #7488 because this wasn't caught by any of the testing we do post packaging including beats-tester.