Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Filebeat modules from packages #7488

Closed
2 tasks done
andrewkroh opened this issue Jul 3, 2018 · 3 comments
Closed
2 tasks done

Test Filebeat modules from packages #7488

andrewkroh opened this issue Jul 3, 2018 · 3 comments
Assignees
@exekias @andrewkroh
Labels
Filebeat Filebeat Metricbeat Metricbeat :Testing

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Jul 3, 2018 •
edited by exekias
Loading

We don't have any tests in place to detect if the Filebeat modules work from the packages we produce. I noticed this because they weren't included in the packages and none of our tests failed. I suggest adding some tests in these areas:

  • Check that packages have modules and modules.d at a minimum. Currently we check file permissions and ownership, but we don't assert they exist. I suggest adding a flag like --modules or --dir to package_test.go that causes the check to test that the directories exist in all packages.

  • Run some tests on the Filebeat modules from beats-tester. Maybe execute the enable commands.
    Test filebeat/metricbeat modules list beats-tester#87
@andrewkroh andrewkroh mentioned this issue Jul 3, 2018
Merged
@andrewkroh andrewkroh added the Metricbeat Metricbeat label Aug 27, 2018
@andrewkroh
Copy link
Member Author

This also applies to Metricbeat modules.

andrewkroh added a commit to andrewkroh/beats-tester that referenced this issue Aug 27, 2018
@andrewkroh
Test filebeat/metricbeat modules list
6e04403 
Test that the `filebeat modules list` and `metricbeat modules list` commands are working.

Relates elastic/beats#7488 elastic/beats#8105
andrewkroh added a commit to andrewkroh/beats-tester that referenced this issue Aug 27, 2018
@andrewkroh
Test filebeat/metricbeat modules list
342a5de 
Test that the `filebeat modules list` and `metricbeat modules list` commands are working.

Relates elastic/beats#7488 elastic/beats#8105
@andrewkroh andrewkroh mentioned this issue Aug 27, 2018
Merged
@andrewkroh
Copy link
Member Author

I opened elastic/beats-tester#87 which runs both filebeat and metricbeat modules list.

@exekias exekias mentioned this issue Aug 28, 2018
Merged
ruflin pushed a commit that referenced this issue Aug 28, 2018
@exekias @ruflin
Test modules and modules.d folder contents in resulting packages (#8107)
aa6c76e 
This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of #7488
@exekias exekias mentioned this issue Aug 28, 2018
Closed
exekias added a commit to exekias/beats that referenced this issue Aug 28, 2018
@exekias
Test modules and modules.d folder contents in resulting packages (ela…
ede5e9d 
…stic#8107)

This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of elastic#7488

(cherry picked from commit aa6c76e)
@exekias exekias mentioned this issue Aug 28, 2018
Merged
exekias added a commit to exekias/beats that referenced this issue Aug 29, 2018
@exekias
Test modules and modules.d folder contents in resulting packages (ela…
8ca2729 
…stic#8107)

This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of elastic#7488

(cherry picked from commit aa6c76e)
@exekias exekias mentioned this issue Aug 29, 2018
Merged
andrewkroh added a commit to elastic/beats-tester that referenced this issue Aug 29, 2018
@andrewkroh
Test filebeat/metricbeat modules list (#87)
87422ae 
Test that the `filebeat modules list` and `metricbeat modules list` commands are working.

Relates elastic/beats#7488 elastic/beats#8105
exekias added a commit that referenced this issue Aug 30, 2018
@exekias
Cherry-pick #8107 to 6.x: Test modules and modules.d folder contents …
d2ec6c5 
…in resulting packages (#8111)

* Test modules and modules.d folder contents in resulting packages (#8107)

This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of #7488

(cherry picked from commit aa6c76e)
exekias added a commit that referenced this issue Aug 30, 2018
@exekias
Cherry-pick #8107 to 6.4: Test modules and modules.d folder contents …
fe9e920 
…in resulting packages (#8136)

* Test modules and modules.d folder contents in resulting packages (#8107)

This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of #7488

(cherry picked from commit aa6c76e)
@exekias
Copy link
Contributor

exekias commented Dec 4, 2018

I guess this one can be closed now @andrewkroh ?

leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@exekias
Cherry-pick elastic#8107 to 6.4: Test modules and modules.d folder co…
487fe4e 
…ntents in resulting packages (elastic#8136)

* Test modules and modules.d folder contents in resulting packages (elastic#8107)

This change ensures that `modules` (Filebeat) and `modules.d` (Filebeat & Metricbeat) folders contain files in the right place.

Permissions and ownership were already tested

Part of elastic#7488

(cherry picked from commit 5577137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exekias exekias

@andrewkroh andrewkroh

Labels
Filebeat Filebeat Metricbeat Metricbeat :Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exekias @andrewkroh