Move Metricbeat modules.d dir to /etc/metricbeat #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the location of the Metricbeat modules.d directory as installed by .deb and .rpm packages. Fixes elastic#8104
andrewkroh
added
bug
review
Metricbeat
|
jenkins, package it |
ruflin
reviewed
Aug 27, 2018
| @@ -126,9 +126,8 @@ func GoTestIntegration(ctx context.Context) error { | |||
| // not supported. | |||
| func customizePackaging() { | |||
| var ( | |||
| archiveModulesDir = "modules.d" | |||
| linuxPkgModulesDir = "/usr/share/{{.BeatName}}/modules.d" | |||
| darwinDMGModulesDir = "/Library/Application Support/{{.BeatVendor}}/{{.BeatName}}/modules.d" | |||
There was a problem hiding this comment.
Is it on purpose that now the Mac files are placed under a different location?
There was a problem hiding this comment.
The new MacOS installer puts our typical path.home files into /Library/Application Support because this is conventional (it's like /usr/share).
The config and logs go to /etc and /var just like Linux. So the modules.d was wrong for MacOS too.
andrewkroh
added a commit
to andrewkroh/beats-tester
that referenced
this pull request
Aug 27, 2018
Test that the `filebeat modules list` and `metricbeat modules list` commands are working. Relates elastic/beats#7488 elastic/beats#8105
andrewkroh
added a commit
to andrewkroh/beats-tester
that referenced
this pull request
Aug 27, 2018
Test that the `filebeat modules list` and `metricbeat modules list` commands are working. Relates elastic/beats#7488 elastic/beats#8105
|
jenkins, package it |
|
Trying to trigger a packaging build here: https://beats-ci.elastic.co/job/elastic+beats+pull-request+package/47/console |
exekias
approved these changes
Aug 29, 2018
andrewkroh
added a commit
to elastic/beats-tester
that referenced
this pull request
Aug 29, 2018
Test that the `filebeat modules list` and `metricbeat modules list` commands are working. Relates elastic/beats#7488 elastic/beats#8105
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Aug 29, 2018
This fixes the location of the Metricbeat modules.d directory as installed by .deb and .rpm packages. Fixes elastic#8104 (cherry picked from commit ac96597)
andrewkroh
added
v6.5.0
and removed
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Aug 29, 2018
This fixes the location of the Metricbeat modules.d directory as installed by .deb and .rpm packages. Fixes elastic#8104 (cherry picked from commit ac96597)
andrewkroh
added a commit
that referenced
this pull request
Aug 30, 2018
exekias
pushed a commit
that referenced
this pull request
Sep 3, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#8152) This fixes the location of the Metricbeat modules.d directory as installed by .deb and .rpm packages. Fixes elastic#8104 (cherry picked from commit b62f374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the location of the Metricbeat modules.d directory as installed by .deb and .rpm packages.
Fixes #8104