Allow TCP helper to support delimiters #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Sep 10, 2018
| } | ||
| } | ||
|
|
||
| func (t *TcpConfig) Validate() error { |
There was a problem hiding this comment.
exported method TcpConfig.Validate should have comment or be unexported
vjsamuel
force-pushed
the
tcp_helper_delimiter
branch
from
e4af891 to
f1f1d29
Compare
houndci-bot
reviewed
Sep 10, 2018
filebeat/inputsource/tcp/client.go
Outdated
| @@ -43,6 +43,8 @@ type client struct { | |||
| timeout time.Duration | |||
| } | |||
|
|
|||
| type ClientFactory func() *client | |||
There was a problem hiding this comment.
exported type ClientFactory should have comment or be unexported
vjsamuel
force-pushed
the
tcp_helper_delimiter
branch
from
f1f1d29 to
8463bff
Compare
vjsamuel
force-pushed
the
tcp_helper_delimiter
branch
from
8463bff to
0a9d978
Compare
jsoriano
requested changes
Sep 11, 2018
metricbeat/helper/server/tcp/tcp.go
Outdated
|
|
||
| // Close connection when this function ends | ||
| defer func() { | ||
| if conn != nil { |
There was a problem hiding this comment.
Can conn be nil here? I'd rather return immediately if that is the case.
jsoriano
approved these changes
Sep 12, 2018
|
@jsoriano thank you for the quick review and merge |
jsoriano
added a commit
that referenced
this pull request
Sep 13, 2018
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Sep 13, 2018
(cherry picked from commit eeb1d3b)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 13, 2018
(cherry picked from commit ff566e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are TCP payloads coming in from graphite carbon forwarders into metricbeat that have many metrics separated by '\n`. What happens is that only the first event is parsed and the rest are dropped.
This PR attempts to allow TCP helper to accept a delimiter character which can be used to split the bytes coming in to the socket and create events for each one of them.