Cherry-pick #8278 to 6.x: Allow TCP helper to support delimiters #8302
Conversation
|
|
||
| length, err := conn.Read(buffer) | ||
| go g.handle(conn) |
There was a problem hiding this comment.
In the original PR, this statement is wrapped in an if conn != nil. Is that needed here too?
| func (g *TcpServer) handle(conn net.Conn) { | ||
| if conn == nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
This if block is not in the original PR. Any specific reason for the difference in the backport?
|
@ycombinator thanks for reviewing this! And sorry for the confusion, I did a follow up PR (#8295) to the original one with some extra details, this one backports both PRs, this is why you see these differences. In the follow up PR I modified the changelog entry to be more explicit on the use case it supports. I also removed the deferred function enclosing |
Cherry-pick of PR #8278 to 6.x branch. Original message:
There are TCP payloads coming in from graphite carbon forwarders into metricbeat that have many metrics separated by '\n`. What happens is that only the first event is parsed and the rest are dropped.
This PR attempts to allow TCP helper to accept a delimiter character which can be used to split the bytes coming in to the socket and create events for each one of them.