-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #8487 to 6.4: Avoid mapping issues in kubernetes module #8507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 3c363a0)
ruflin
reviewed
Oct 1, 2018
CHANGELOG.asciidoc
Outdated
@@ -41,6 +41,8 @@ https://github.com/elastic/beats/compare/v6.4.1...6.4[Check the HEAD diff] | |||
*Metricbeat* | |||
|
|||
- Fix incorrect type conversion of average response time in Haproxy dashboards {pull}8404[8404] | |||
- Fix dropwizard module parsing of metric names. {issue}8365[8365] {pull}6385[8385] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed I think?
ruflin
reviewed
Oct 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides CHANGELOG LGTM
WFG |
I had to merge 6.4 back as 6.4.2 was released, only conflict was on changelog |
ruflin
approved these changes
Oct 4, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…odule (elastic#8507) * Avoid mapping issues in kubernetes module (elastic#8487) * Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 8d72865) * Update CHANGELOG.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8487 to 6.4 branch. Original message:
This contains 2 changes:
start_time
when it's empty, as that will throw amapping exception
fields.yml
, as some fields were out of place forevent
metricset
closes #7736