Avoid mapping issues in kubernetes module #8487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
bug
module
review
Metricbeat
This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset
exekias
force-pushed
the
fix-start_time-mapping-issues
branch
from
0c4f702 to
94ae4dc
Compare
|
Changes LGTM but it will need a Is there a reason these two changes are connected together? Will this need a backport? |
exekias
added
the
needs_backport
|
Thanks for the review, they are not that connected 😇 but both could potentially cause mapping issues so I addressed them together. I think this should be backported to 6.x & 6.4 branches |
exekias
added
v6.5.0
and removed
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 1, 2018
* Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 3c363a0)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 1, 2018
* Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 3c363a0)
exekias
added a commit
that referenced
this pull request
Oct 3, 2018
…8506) * Avoid mapping issues in kubernetes module (#8487) * Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 3c363a0) * Update CHANGELOG.asciidoc
exekias
added a commit
that referenced
this pull request
Oct 4, 2018
…8507) * Avoid mapping issues in kubernetes module (#8487) * Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 3c363a0) * Update CHANGELOG.asciidoc
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…odule (elastic#8507) * Avoid mapping issues in kubernetes module (elastic#8487) * Avoid mapping issues in kubernetes module This contains 2 changes: * Do not report `start_time` when it's empty, as that will throw a mapping exception * Fix `fields.yml`, as some fields were out of place for `event` metricset (cherry picked from commit 8d72865) * Update CHANGELOG.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains 2 changes:
start_timewhen it's empty, as that will throw amapping exception
fields.yml, as some fields were out of place foreventmetricset
closes #7736