Better error messaging for Elastic stacks' metricsets #8551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
in progress
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
2 times, most recently
from
fbe4e4e to
2f8b96d
Compare
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
from
cbc0606 to
b250cc4
Compare
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
from
b250cc4 to
f689ad9
Compare
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
from
17d4f2d to
073d197
Compare
ycombinator
added
review
and removed
in progress
14 tasks
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
3 times, most recently
from
d08395d to
7a5554b
Compare
ycombinator
force-pushed
the
metricbeat-xpack-better-error-msgs
branch
from
7a5554b to
357f9e6
Compare
|
jenkins, test this |
ruflin
approved these changes
Oct 4, 2018
| @@ -20,6 +20,10 @@ package stats | |||
| import ( | |||
| "encoding/json" | |||
|
|
|||
| "github.com/elastic/beats/metricbeat/module/kibana" | |||
There was a problem hiding this comment.
Import mess, but no need to fix now.
There was a problem hiding this comment.
Fixed in 077d919.
|
@ruflin Cleaned up imports. Still LGTM? |
|
@ycombinator Yes |
14 tasks
ycombinator
removed
the
needs_backport
ycombinator
added a commit
that referenced
this pull request
Oct 5, 2018
…metricsets (#8577) Cherry-pick of PR #8551 to 6.x branch. Original message: This PR makes error messages better and more consistent across all metricsets for Elastic stack products, including the xpack monitoring code paths: * [x] `elasticsearch/ccr` * [x] `elasticsearch/cluster_stats` * [x] `elasticsearch/index` * [x] `elasticsearch/index_recovery` * [x] `elasticsearch/index_summary` * [x] `elasticsearch/ml_job` * [x] `elasticsearch/node` * [x] `elasticsearch/node_stats` * [x] `elasticsearch/pending_tasks` * [x] `elasticsearch/shard` * [x] `kibana/status` * [x] `kibana/stats` * [x] `logstash/node` * [x] `logstash/node_stats`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes error messages better and more consistent across all metricsets for Elastic stack products, including the xpack monitoring code paths:
elasticsearch/ccrelasticsearch/cluster_statselasticsearch/indexelasticsearch/index_recoveryelasticsearch/index_summaryelasticsearch/ml_jobelasticsearch/nodeelasticsearch/node_statselasticsearch/pending_taskselasticsearch/shardkibana/statuskibana/statslogstash/nodelogstash/node_stats