Cherry-pick #8551 to 6.x: Better error messaging for Elastic stacks' metricsets #8577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better error messaging for elasticsearch/ccr metricset * Better error messaging for elasticsearch/cluster_stats metricset * Better error messaging for elasticsearch/index metricset * Better error messaging for elasticsearch/index_recovery metricset * Better error messaging for elasticsearch/index_summary metricset * Better error messaging for elasticsearch/ml_job metricset * Better error messaging for elasticsearch/node metricset * Better error messaging for elasticsearch/node_stats metricset * Better error messaging for elasticsearch/pending_tasks metricset * Better error messaging for elasticsearch/shard metricset * Better error messaging for kibana/stats metricset * Better error messaging for kibana/status metricset * Better error messaging for logstash/node metricset * Better error messaging for logstash/node_stats metricset * Cleaning up imports (cherry picked from commit a164d7b)
|
jenkins, test this |
ruflin
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8551 to 6.x branch. Original message:
This PR makes error messages better and more consistent across all metricsets for Elastic stack products, including the xpack monitoring code paths:
elasticsearch/ccrelasticsearch/cluster_statselasticsearch/indexelasticsearch/index_recoveryelasticsearch/index_summaryelasticsearch/ml_jobelasticsearch/nodeelasticsearch/node_statselasticsearch/pending_taskselasticsearch/shardkibana/statuskibana/statslogstash/nodelogstash/node_stats