Fix kafka broker matching when port is not set #8613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Metricbeat
houndci-bot
reviewed
Oct 14, 2018
metricbeat/module/kafka/broker.go
Outdated
| return os.Hostname() | ||
| } | ||
|
|
||
| type BrokerFinder struct { |
There was a problem hiding this comment.
exported type BrokerFinder should have comment or be unexported
Fix kafka broker matching when port is not set and add tests for broker matcher function.
jsoriano
force-pushed
the
kafka-broker-matching
branch
from
dc66a5a to
a41f8d7
Compare
|
Could it be that you have go 1.11 locally? fmt rules are a bit different for 1.10.3 |
|
Failures seem caused by some change in upstream goimports, trying to vendorize it in #8619. |
ruflin
approved these changes
Oct 17, 2018
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 17, 2018
Fix kafka broker matching when port is not set and add tests for broker matcher function. (cherry picked from commit 1603e64)
jsoriano
added a commit
that referenced
this pull request
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix kafka broker matching when port is not set and add tests
for broker matcher function.