Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendorize goimports #8619

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Vendorize goimports #8619

merged 1 commit into from
Oct 16, 2018

Conversation

jsoriano
Copy link
Member

CI builds are failing because of some change on goimports or its dependencies, vendorize it with 1.10 branch.

@jsoriano
Copy link
Member Author

Vendorized in the wrong place 🤦‍♂️ fixing it...

@jsoriano jsoriano force-pushed the vendor-goimports branch 2 times, most recently from 79e030e to 7899525 Compare October 15, 2018 20:05
@ruflin ruflin merged commit d1734f4 into elastic:master Oct 16, 2018
@ruflin
Copy link
Contributor

ruflin commented Oct 16, 2018

@jsoriano Cany ou backport this to 6.x? I think there PR's are also failing.

ruflin pushed a commit to ruflin/beats that referenced this pull request Oct 16, 2018
(cherry picked from commit d1734f4)
@jsoriano jsoriano deleted the vendor-goimports branch October 16, 2018 08:30
ruflin added a commit that referenced this pull request Oct 16, 2018
(cherry picked from commit d1734f4)
@andrewvc andrewvc mentioned this pull request Oct 16, 2018
adriansr pushed a commit to adriansr/beats that referenced this pull request Oct 16, 2018
adriansr added a commit that referenced this pull request Oct 16, 2018
* Vendorize goimports (#8619)

* Fix make fmt after vendoring goimports (#8623)
jsoriano added a commit to jsoriano/beats that referenced this pull request Oct 17, 2018
(cherry picked from commit d1734f4)
jsoriano added a commit that referenced this pull request Oct 17, 2018
Vendorize goimports (#8619 and #8626)

Co-authored-by: Gil Raphaelli <g@raphaelli.com>

(cherry picked from commits d1734f4 and  db89540)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Vendorize goimports (elastic#8619 and elastic#8626)

Co-authored-by: Gil Raphaelli <g@raphaelli.com>

(cherry picked from commits 6172a96 and  e7f620f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug flaky-test Unstable or unreliable test cases. libbeat review v6.4.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants