Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #8617

Merged
merged 7 commits into from
Oct 24, 2018
Merged

Fix typo #8617

merged 7 commits into from
Oct 24, 2018

Conversation

robin13
Copy link
Contributor

@robin13 robin13 commented Oct 15, 2018

No description provided.

@andrewvc
Copy link
Contributor

Looks good, but weird failures. make check works locally, but not here.

Jenkins, retest this please.

As an aside @robin13 generally it's better to make a new branch that's based off beats/master and open a PR from that. The history on this PR is weird because it has merge commits from beats/master.

Ideally you'd use git checkout -b myfeaturebranch origin/master if elastic/beats is origin. And then you'd push myfeaturebranch.

@andrewvc
Copy link
Contributor

@robin13 can you try pulling in the latest off master and rebasing off that? I'm wondering if that will fix the build now that #8619 is merged

@andrewvc
Copy link
Contributor

jenkins, retest this please

@andrewvc andrewvc merged commit 948c17b into elastic:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin13 @andrewvc @ruflin