Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rely on go to resolve beats repo for goimports install #8626

Merged
merged 1 commit into from
Oct 16, 2018
Merged

rely on go to resolve beats repo for goimports install #8626

merged 1 commit into from
Oct 16, 2018

Conversation

graphaelli
Copy link
Member

as done for github.com/pierrre/gotestcover, github.com/stretchr/testify/assert, etc.

following up on #8619

jsoriano
jsoriano approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, this is probably better 👍

@jsoriano jsoriano added review libbeat needs_backport PR is waiting to be backported to other branches. v6.5.0 labels Oct 16, 2018
@ruflin ruflin merged commit db89540 into elastic:master Oct 16, 2018
@ruflin
Copy link
Contributor

ruflin commented Oct 16, 2018

@graphaelli Do you want to backport it?

@graphaelli
Copy link
Member Author

sure, will do

@graphaelli graphaelli deleted the goimports branch October 16, 2018 18:50
@graphaelli
Copy link
Member Author

Good news, this resolved the beats-update issue for apm-server

@graphaelli graphaelli mentioned this pull request Oct 16, 2018
Merged
@graphaelli graphaelli removed the needs_backport PR is waiting to be backported to other branches. label Oct 16, 2018
graphaelli added a commit to graphaelli/beats that referenced this pull request Oct 16, 2018
@graphaelli
rely on go to resolve beats repo for goimports install (elastic#8626)
8ba293d 
(cherry picked from commit db89540)
ruflin pushed a commit that referenced this pull request Oct 17, 2018
@graphaelli @ruflin
rely on go to resolve beats repo for goimports install (#8626) (#8630)
58a2897 
(cherry picked from commit db89540)
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Oct 17, 2018
@graphaelli @jsoriano
rely on go to resolve beats repo for goimports install (elastic#8626)
30bd220 
(cherry picked from commit db89540)
@jsoriano jsoriano mentioned this pull request Oct 17, 2018
Merged
jsoriano added a commit that referenced this pull request Oct 17, 2018
@jsoriano
Cherry-pick #8619 to 6.4: Vendorize goimports (#8632)
151c55e 
Vendorize goimports (#8619 and #8626)

Co-authored-by: Gil Raphaelli <g@raphaelli.com>

(cherry picked from commits d1734f4 and  db89540)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Cherry-pick elastic#8619 to 6.4: Vendorize goimports (elastic#8632)
5013e8d 
Vendorize goimports (elastic#8619 and elastic#8626)

Co-authored-by: Gil Raphaelli <g@raphaelli.com>

(cherry picked from commits 6172a96 and  e7f620f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
libbeat review v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graphaelli @ruflin @jsoriano