Generate fields.go for netflow input #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
the
needs_backport
Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. Also add headers to the modules.d config files.
andrewkroh
force-pushed
the
feature/fb/netflow-fields-go
branch
from
c2f6ccd to
61102de
Compare
|
Pinging @elastic/secops |
It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers.
7 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Dec 21, 2018
* Generate fields.go for netflow input Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. * Fix netflow exporter version datatype It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers. Cherry-pick parts of 01ae538 (elastic#9686)
andrewkroh
added a commit
that referenced
this pull request
Dec 21, 2018
* Backport fields generation code Cherry-pick select parts of eb1739e * Generate fields.go for netflow input * Generate fields.go for netflow input Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. * Fix netflow exporter version datatype It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers. Cherry-pick parts of 01ae538 (#9686) * Update x-pack/filebeat to use the xpack.mk The existing Filebeat Makefile could not be reused because generate_imports.py is not portable. * Add clean and exportDashboard targets * createDir in GenerateModuleReferenceConfig * Remove makefile hack to test x-pack/filebeat
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Dec 21, 2018
* Backport fields generation code Cherry-pick select parts of eb1739e * Generate fields.go for netflow input * Generate fields.go for netflow input Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. * Fix netflow exporter version datatype It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers. Cherry-pick parts of 01ae538 (elastic#9686) * Update x-pack/filebeat to use the xpack.mk The existing Filebeat Makefile could not be reused because generate_imports.py is not portable. * Add clean and exportDashboard targets * createDir in GenerateModuleReferenceConfig * Remove makefile hack to test x-pack/filebeat (cherry picked from commit 09f0159)
andrewkroh
added a commit
that referenced
this pull request
Dec 22, 2018
* Backport fields generation code Cherry-pick select parts of eb1739e * Generate fields.go for netflow input * Generate fields.go for netflow input Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. * Fix netflow exporter version datatype It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers. Cherry-pick parts of 01ae538 (#9686) * Update x-pack/filebeat to use the xpack.mk The existing Filebeat Makefile could not be reused because generate_imports.py is not portable. * Add clean and exportDashboard targets * createDir in GenerateModuleReferenceConfig * Remove makefile hack to test x-pack/filebeat (cherry picked from commit 09f0159)
andrewkroh
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Backport fields generation code Cherry-pick select parts of f54df4f * Generate fields.go for netflow input * Generate fields.go for netflow input Update x-pack/filebeat to generate a fields.go for each input type. And update the code that generates the include/list.go to import each input. * Fix netflow exporter version datatype It was "int" which is not a valid type. Changed it to long rather than integer because we use that everywhere for numbers. Cherry-pick parts of c44eb1b (elastic#9686) * Update x-pack/filebeat to use the xpack.mk The existing Filebeat Makefile could not be reused because generate_imports.py is not portable. * Add clean and exportDashboard targets * createDir in GenerateModuleReferenceConfig * Remove makefile hack to test x-pack/filebeat (cherry picked from commit 162f255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the netflow fields are embedded in the filebeat binary for template purposes.
Update x-pack/filebeat to generate a fields.go for each input type. And update the code that
generates the include/list.go to import each input.
Also add headers to the modules.d config files.