Update Filebeat's magefile.go #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 20, 2018
andrewkroh
force-pushed
the
feature/fb/improve-magefiles
branch
3 times, most recently
from
2d675d1 to
a0ab47f
Compare
ruflin
approved these changes
Dec 20, 2018
| @@ -5,9 +5,13 @@ services: | |||
| depends_on: | |||
| - proxy_dep | |||
| env_file: | |||
| - ${PWD}/build/test.env | |||
There was a problem hiding this comment.
I might bring it back as a static file someday. But for now a little duplication makes migration away from Make easier.
| @@ -30,11 +30,13 @@ grouped in the following categories: | |||
| * <<exported-fields-logstash>> | |||
| * <<exported-fields-mongodb>> | |||
| * <<exported-fields-mysql>> | |||
| * <<exported-fields-netflow>> | |||
There was a problem hiding this comment.
I haven't checked 6.x, but are fields there showing up or does this need backport?
There was a problem hiding this comment.
The x-pack fields aren't in the docs in 6.x. This will need a "backport" (using quotes b/c it may be easier to just copy over the parts we need since they are spread across commits in master).
| @@ -0,0 +1,12 @@ | |||
| filebeat.config: | |||
There was a problem hiding this comment.
Is this file used during packaging?
There was a problem hiding this comment.
Yeah, it gets included in the docker images as filebeat.yml.
This improves and fixes a few issues. - Generate field docs that include fields from x-pack/filebeat. - Generate fields.go for each Filebeat module. - Add direct packaging build targets to x-pack/filebeat (packaging is no longer done via OSS filebeat).
andrewkroh
force-pushed
the
feature/fb/improve-magefiles
branch
from
43364ee to
f67edfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves and fixes a few issues.
This PR is based on #9686 so I'll rebased it after that merges. So review the last commit only a0ab47f.