Rename nodes to nodeSets, nodeCount to count #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
requested review from
sebgl,
thbkrkr and
charith-elastic
and removed request for
sebgl and
thbkrkr
pebrc
commented
Oct 2, 2019
NOTICE.txt
Outdated
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
|
|
||
|
|
There was a problem hiding this comment.
Not entirely sure where this is coming from
pebrc
commented
Oct 2, 2019
| connect to. | ||
| type: string | ||
| type: object | ||
| type: object |
There was a problem hiding this comment.
Now that we introduce a difference between versions, the schema is gone for APM/Kibana too :-(
There was a problem hiding this comment.
Well, at least that's consistent 😄
This comment has been minimized.
This comment has been minimized.
thbkrkr
reviewed
Oct 2, 2019
thbkrkr
reviewed
Oct 2, 2019
|
Jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says in the title. I am unsure about the the
nodeCountrename for Kibana and APM but thought we should aim for consistency.Fixes #1488