Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nodes to nodeSets, nodeCount to count #1843

Merged
merged 13 commits into from
Oct 2, 2019
29 changes: 0 additions & 29 deletions NOTICE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,6 @@ Third party libraries used by the Elastic Cloud on Kubernetes project
================================================================================


--------------------------------------------------------------------------------
Module : github.com/Masterminds/sprig
Version : v2.20.0+incompatible
Time : 2019-06-18 15:54:40 +0000 UTC

Contents of probable licence file $GOMODCACHE/github.com/!masterminds/sprig@v2.20.0+incompatible/LICENSE.txt:

Sprig
Copyright (C) 2013 Masterminds

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure where this is coming from

--------------------------------------------------------------------------------
Module : github.com/davecgh/go-spew
Version : v1.1.1
Expand Down
336 changes: 0 additions & 336 deletions config/crds/apm.k8s.elastic.co_apmservers.yaml

Large diffs are not rendered by default.

326 changes: 0 additions & 326 deletions config/crds/kibana.k8s.elastic.co_kibanas.yaml

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions config/samples/apm/apm_es_kibana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ metadata:
name: es-apm-sample
spec:
version: 7.4.0
nodes:
nodeSets:
- name: default
nodeCount: 3
count: 3
---
apiVersion: apm.k8s.elastic.co/v1beta1
kind: ApmServer
metadata:
name: apm-apm-sample
spec:
version: 7.4.0
nodeCount: 1
count: 1
elasticsearchRef:
name: "es-apm-sample"
---
Expand All @@ -26,6 +26,6 @@ metadata:
name: kb-apm-sample
spec:
version: 7.4.0
nodeCount: 1
count: 1
elasticsearchRef:
name: "es-apm-sample"
2 changes: 1 addition & 1 deletion config/samples/apm/apmserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: apmserver-sample
spec:
version: 7.4.0
nodeCount: 1
count: 1
config:
output.console:
pretty: true
Expand Down
4 changes: 2 additions & 2 deletions config/samples/elasticsearch/elasticsearch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: elasticsearch-sample
spec:
version: 7.4.0
nodes:
nodeSets:
- name: default
config:
# most Elasticsearch configuration parameters are possible to set, e.g:
Expand All @@ -30,7 +30,7 @@ spec:
env:
- name: ES_JAVA_OPTS
value: "-Xms2g -Xmx2g"
nodeCount: 3
count: 3
# # request 2Gi of persistent data storage for pods in this topology element
# volumeClaimTemplates:
# - metadata:
Expand Down
28 changes: 18 additions & 10 deletions config/samples/kibana/kibana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,24 @@ metadata:
name: kibana-sample
spec:
version: 7.4.0
elasticsearch:
url: https://url.to.elasticsearch:9200
auth:
# reference to a secret containing credentials in the given key
secret:
name: secret-name
key: user # key is the user, value is the password for that user
certificateAuthorities:
secretName: my-ca-cert # reference to a secret containing certificates under "tls.crt"
nodeCount: 1
config:
elasticsearch.hosts:
- https://url.to.elasticsearch:9200
elasticsearch.username: my-kibana-user
elasticsearch.password: $PASSWORD
elasticsearch.ssl.certificateAuthorities: /mnt/certs/elasticsearch/ca.crt
count: 1
podTemplate:
spec:
containers:
- name: kibana
volumeMounts:
- name: certs
mountPath: /mnt/certs/elasticsearch
volumes:
- name: certs
secret:
secretName: my-es-http-certs
# http:
# service:
# spec:
Expand Down
6 changes: 3 additions & 3 deletions config/samples/kibana/kibana_es.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ metadata:
name: elasticsearch-sample
spec:
version: 7.4.0
nodes:
nodeSets:
- name: default
nodeCount: 1
count: 1
---
apiVersion: kibana.k8s.elastic.co/v1beta1
kind: Kibana
metadata:
name: kibana-sample
spec:
version: 7.4.0
nodeCount: 1
count: 1
elasticsearchRef:
name: "elasticsearch-sample"
#http:
Expand Down
48 changes: 29 additions & 19 deletions docs/advanced-node-scheduling.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,18 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
nodeSets:
# 3 dedicated master nodes
- nodeCount: 3
- name: master
count: 3
config:
node.master: true
node.data: false
node.ingest: false
cluster.remote.connect: false
# 3 ingest-data nodes
- nodeCount: 3
- name: ingest-data
count: 3
config:
node.master: false
node.data: true
Expand All @@ -60,8 +62,8 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodesSets:
- count: 3
podTemplate:
spec:
affinity:
Expand All @@ -87,8 +89,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podTemplate:
spec:
affinity: {}
Expand All @@ -104,8 +107,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podTemplate:
spec:
affinity:
Expand Down Expand Up @@ -149,8 +153,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podTemplate:
spec:
nodeSelector:
Expand All @@ -168,8 +173,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podTemplate:
spec:
affinity:
Expand Down Expand Up @@ -208,8 +214,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 1
nodeSets:
- name: group-a
count: 1
config:
node.attr.zone: europe-west3-a
cluster.routing.allocation.awareness.attributes: zone
Expand All @@ -227,7 +234,8 @@ spec:
operator: In
values:
- europe-west3-a
- nodeCount: 1
- name: group-b
count: 1
config:
node.attr.zone: europe-west3-b
cluster.routing.allocation.awareness.attributes: zone
Expand Down Expand Up @@ -276,9 +284,10 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
nodeSets:
# hot nodes, with high CPU and fast IO
- nodeCount: 3
- name: hot
count: 3
config:
node.attr.data: hot
podTemplate:
Expand Down Expand Up @@ -309,7 +318,8 @@ spec:
storage: 1Ti
storageClassName: local-storage
# warm nodes, with high storage
- nodeCount: 3
- name: warm
count: 3
config:
node.attr.data: warm
podTemplate:
Expand Down
8 changes: 4 additions & 4 deletions docs/apm.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ metadata:
namespace: default
spec:
version: {version}
nodeCount: 1
count: 1
elasticsearchRef:
name: quickstart
EOF
Expand Down Expand Up @@ -87,7 +87,7 @@ metadata:
namespace: default
spec:
version: {version}
nodeCount: 1
count: 1
config:
output:
elasticsearch:
Expand Down Expand Up @@ -122,7 +122,7 @@ metadata:
namespace: default
spec:
version: {version}
nodeCount: 1
count: 1
secureSettings:
- secretName: apm-secret-settings
config:
Expand Down Expand Up @@ -161,7 +161,7 @@ metadata:
namespace: default
spec:
version: {version}
nodeCount: 1
count: 1
secureSettings:
- secretName: apm-secret-settings
config:
Expand Down
12 changes: 7 additions & 5 deletions docs/elasticsearch-spec.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ But you can use the same approach for any kind of file you want to mount into th
[source,yaml]
----
spec:
nodes:
nodeSets:
- podTemplate:
spec:
containers:
Expand Down Expand Up @@ -411,8 +411,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podDisruptionBudget:
spec:
maxUnavailable: 2
Expand All @@ -431,8 +432,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
podDisruptionBudget: {}
----

Expand Down
15 changes: 9 additions & 6 deletions docs/k8s-quickstart.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 1
nodeSets:
- name: default
count: 1
config:
node.master: true
node.data: true
Expand Down Expand Up @@ -182,7 +183,7 @@ metadata:
name: quickstart
spec:
version: {version}
nodeCount: 1
count: 1
elasticsearchRef:
name: quickstart
EOF
Expand Down Expand Up @@ -247,7 +248,8 @@ metadata:
spec:
version: {version}
nodes:
pebrc marked this conversation as resolved.
Show resolved Hide resolved
- nodeCount: 3
- name: default
count: 3
config:
node.master: true
node.data: true
Expand All @@ -272,8 +274,9 @@ metadata:
name: quickstart
spec:
version: {version}
nodes:
- nodeCount: 3
nodeSets:
- name: default
count: 3
config:
node.master: true
node.data: true
Expand Down
Loading