Allow user to override readiness timeout #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-kow
approved these changes
Dec 13, 2019
sebgl
reviewed
Dec 13, 2019
| @@ -30,7 +30,7 @@ const ReadinessProbeScriptConfigKey = "readiness-probe-script.sh" | |||
| const ReadinessProbeScript string = ` | |||
| #!/usr/bin/env bash | |||
| # Consider a node to be healthy if it responds to a simple GET on "/_cat/nodes?local" | |||
| CURL_TIMEOUT=3 | |||
| CURL_TIMEOUT=${CURL_TIMEOUT:=3} | |||
There was a problem hiding this comment.
I feel like this env var name should be more explicit: READINESS_CURL_TIMEOUT
There was a problem hiding this comment.
Agreed, I'll open a new PR
mjmbischoff
pushed a commit
to mjmbischoff/cloud-on-k8s
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2259
Default the readiness timeout 3s, but allow the user to set an env var to override the timeout for clusters that are under load. Currently it is hardcoded so changing the timeout means you need to change the whole readiness probe