Change readiness timeout var #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
approved these changes
Dec 16, 2019
thbkrkr
reviewed
Dec 16, 2019
| - name: elasticsearch | ||
| env: | ||
| - name: READINESS_PROBE_TIMEOUT | ||
| value: 10 |
There was a problem hiding this comment.
I fear that this is not enough because the probe has also a timeout defined at the container level in the spec (set to 5sec).
cloud-on-k8s/pkg/controller/elasticsearch/nodespec/readiness_probe.go
Lines 14 to 20 in 0728ae2
There was a problem hiding this comment.
Good catch, I updated the docs with an example and tested it out
mjmbischoff
pushed a commit
to mjmbischoff/cloud-on-k8s
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2260
Changing the name of the env var and adding some docs