Add the transport service DNS name to the CSR #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially connect through the transport service to the remote cluster. This should ensure that the transport service is one of the trusted DNS names.
anyasabo
reviewed
Mar 10, 2020
| @@ -87,6 +87,8 @@ func buildGeneralNames( | |||
| generalNames := []certificates.GeneralName{ | |||
| {OtherName: *commonNameOtherName}, | |||
| {DNSName: commonName}, | |||
| // add the transport service name for remote cluster connections initially connecting through the service | |||
| {DNSName: fmt.Sprintf("%s.%s.svc", esv1.TransportService(cluster.Name), cluster.Namespace)}, | |||
There was a problem hiding this comment.
We have GetServiceDNSName() in pkg/util/k8s which might be better to use here, and also includes the name without .svc (which also works)
There was a problem hiding this comment.
It will not work unless we also change the seed hosts
There was a problem hiding this comment.
Makes sense, would a comment be helpful here to explain why we're not? It seems like a gotcha since the name resolves. Though to be fair, the fully qualified domain name with the default domain suffix (e.g. cluster.local) also resolves but would fail.
barkbay
approved these changes
Mar 11, 2020
| @@ -87,6 +87,8 @@ func buildGeneralNames( | |||
| generalNames := []certificates.GeneralName{ | |||
| {OtherName: *commonNameOtherName}, | |||
| {DNSName: commonName}, | |||
| // add the transport service name for remote cluster connections initially connecting through the service | |||
| {DNSName: fmt.Sprintf("%s.%s.svc", esv1.TransportService(cluster.Name), cluster.Namespace)}, | |||
There was a problem hiding this comment.
It will not work unless we also change the seed hosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially connect through the transport service to the remote
cluster. This should ensure that the transport service is one of the trusted
DNS names.
I ran into errors like this one when testing remote cluster connection setup