-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix having multiple type
keys in eck-beats chart
#7523
Merged
naemono
merged 2 commits into
elastic:main
from
naemono:fix-beats-chart-multiple-type-keys
Feb 1, 2024
Merged
Fix having multiple type
keys in eck-beats chart
#7523
naemono
merged 2 commits into
elastic:main
from
naemono:fix-beats-chart-multiple-type-keys
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
requested review from
thbkrkr,
pebrc,
barkbay,
rhr323 and
kvalliyurnatt
February 1, 2024 01:57
thbkrkr
reviewed
Feb 1, 2024
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
changed the title
Use
Fix having multiple Feb 1, 2024
omit
to not have multiple type
keys in eck-beats chart.type
keys in eck-beats chart.
thbkrkr
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine run elasticsearch-ci/docs |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
naemono
added a commit
to naemono/cloud-on-k8s
that referenced
this pull request
Feb 1, 2024
* Fix multiple `type` keys in eck-beats chart. --------- Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 91d6639)
naemono
added a commit
that referenced
this pull request
Feb 1, 2024
* Fix multiple `type` keys in eck-beats chart. --------- Signed-off-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit 91d6639)
thbkrkr
changed the title
Fix having multiple
Fix having multiple Mar 4, 2024
type
keys in eck-beats chart.type
keys in eck-beats chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where there were multiple
type
keys in the rendered eck-beats chart.Resolves #7487.