Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix having multiple type keys in eck-beats chart #7523

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix having multiple type keys in eck-beats chart #7523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8439a0d
Use omit to not have multiple "type" keys in eck-beats chart.
naemono Feb 1, 2024
1203ea6
Adjust approach slightly from review.
naemono Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/eck-stack/charts/eck-beats/templates/beats.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ metadata:
{{- end }}
spec:
version: {{ required "A Beat version is required" .Values.version }}
type: {{ required "A Beat type is required" .Values.spec.type }}
{{- if and (not (hasKey .Values.spec "daemonSet")) (not (hasKey .Values.spec "deployment")) }}
{{ fail "At least one of daemonSet or deployment is required for a functional Beat" }}
{{- end }}
{{- if not .Values.spec.type }}{{ fail "A Beat type is required" }}{{- end }}
{{- toYaml .Values.spec | nindent 2 }}