Move Logs, Metrics, and Uptime docs to legacy docs #1985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtback
requested changes
Oct 19, 2020
There was a problem hiding this comment.
This seems fine to me, just one small thing to change.
Also, I'm guessing we'll want to wait until the 7.10 release to actually merge this? In the meantime, we might want to take 7.10, 7.x, and master out of the version list for these books, but it's probably not necessary to do so.
gtback
approved these changes
Oct 19, 2020
|
Thanks @dedemorton I'll update the broken links and add you as a reviewer. |
This was referenced Oct 20, 2020
|
@elasticmachine, run elasticsearch-ci/docs rebuild |
bmorelli25
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
🟢❗Nice.
I'd just merge this PR into @jmikell821's 7.10 conf.yaml PR (when it exists) so that it goes out with the release.
|
I've merged these commits into #1994, so IMO this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until 7.10 is released.
This PR moves the content for the Logs, Metrics, and Uptime Monitoring Guides to the Legacy docs section.
From the 7.10 release onwards, the content for the Logs, Metrics, and Uptime apps is in the
docs/en/observabilityfolder in the observability-docs repo.Related issue:
elastic/observability-docs#189