Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken references to public doc_links #3133

Merged

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 2, 2024

The referenced file in the Kibana repo has been in a different location for a while.
A PR build recently failed, and I believe it might be caused by the outdated paths fixed with this PR.

🔨 Build docs PR
.buildkite/scripts/build_pr.sh
...
INFO:build_docs:Can't read /doc/product-repo/src/core/public/doc_links/doc_links_service.ts: No such file or directory at lib/ES/Repo.pm line 363.

@gsoldevila gsoldevila requested a review from a team as a code owner December 2, 2024 10:55
Copy link

github-actions bot commented Dec 2, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@lcawl
Copy link
Contributor

lcawl commented Dec 2, 2024

Per slack conversation, I think the changes in build_docs.pl need to account for the location of the file in the old branches of the kibana repo. The current build error is:

Path 'packages/core/doc-links/core-doc-links-browser-internal/src/doc_links_service.ts' does not exist in '7.13'

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsoldevila gsoldevila merged commit 3decf4d into elastic:master Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants