Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken references to public doc_links #3133

Merged
merged 6 commits into from
Dec 4, 2024
+9 −0
Merged

Fix broken references to public doc_links #3133

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d855e9
Fix broken references to public doc_links
gsoldevila Dec 2, 2024
a0403eb
Include new location for `get_doc_links.ts`
gsoldevila Dec 2, 2024
c6cad75
Continue to support 7.13
gsoldevila Dec 3, 2024
3039bb6
Use old paths in tests (new ones are too long)
gsoldevila Dec 3, 2024
5f806b5
Include future location of doc-links packages
gsoldevila Dec 3, 2024
93733db
Update old test references
gsoldevila Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions build_docs.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,9 @@ sub check_kibana_links {
say " Branch: $branch, Version: $version";
my $links_file;
my $source = eval {
$links_file = "src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts";
$repo->show_file( $link_check_name, $branch, $links_file );
} || eval {
$links_file = "packages/kbn-doc-links/src/get_doc_links.ts";
$repo->show_file( $link_check_name, $branch, $links_file );
} || eval {
Expand All @@ -427,6 +430,12 @@ sub check_kibana_links {
} || eval {
$links_file = $legacy_path . ".ts";
$repo->show_file( $link_check_name, $branch, $links_file );
} || eval {
$links_file = "src/core/packages/doc-links/core-doc-links-browser-internal/src/doc_links_service.ts";
$repo->show_file( $link_check_name, $branch, $links_file );
} || eval {
$links_file = "packages/core/doc-links/core-doc-links-browser-internal/src/doc_links_service.ts";
$repo->show_file( $link_check_name, $branch, $links_file );
} || eval {
$links_file = "src/core/public/doc_links/doc_links_service.ts";
$repo->show_file( $link_check_name, $branch, $links_file );
Expand Down