Set embedding size for Text Embedding models #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
the
topic:NLP
davidkyle
added a commit
to davidkyle/eland
that referenced
this pull request
May 3, 2023
…elastic#532)" This reverts commit 50d301f.
picandocodigo
pushed a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/elasticsearch#95176 added the
embedding_sizefield to text embedding model configs. The field is set at creation and cannot be changed.This change now sets
embedding_sizewhen creating the config for text embedding models. The embedding size is found by evaluating the model and taking the length of the last dimension of the output tensor