[ML] Add embedding_size to text embedding config #95176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
|
Hi @davidkyle, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
reviewed
Apr 12, 2023
| ) { | ||
| this.vocabularyConfig = Optional.ofNullable(vocabularyConfig) | ||
| .orElse(new VocabularyConfig(InferenceIndexConstants.nativeDefinitionStore())); | ||
| this.tokenization = tokenization == null ? Tokenization.createDefault() : tokenization; | ||
| this.resultsField = resultsField; | ||
| this.embeddingSize = embeddingSize; |
There was a problem hiding this comment.
Since this is serialized as strictly non-negative there should be a check in the public constructor that a negative number hasn't been supplied.
There was a problem hiding this comment.
👍 I've added that check to the ctor, it makes no sense for the size to be <= 0
commit: 1fbbdde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional field
embedding_sizeto the text embedding config for NLP models. The field should be set at model creation and cannot be modified later. If definedembedding_sizeshould be used to set the number of dimensions for the dense_vector field mapping the embedding will be indexed in.