Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5712) Fix typo in float format for APM_SAMPLING_RATE #5714

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

What does this PR do?

Fix float format specification for APM_SAMPLING_RATE

Why is it important?

Agent will not start because apm.Tracer will error out when a badly formatted sampling rate is passed as environment variable

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5712 done by [Mergify](https://mergify.com).

* Fix float format for APM_SAMPLING_RATE

(cherry picked from commit 862b044)
@mergify mergify bot requested a review from a team as a code owner October 7, 2024 12:22
@mergify mergify bot added the backport label Oct 7, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team October 7, 2024 12:22
@mergify mergify bot assigned pchila Oct 7, 2024
@pchila pchila enabled auto-merge (squash) October 7, 2024 12:58
@pchila pchila merged commit 04f258c into 8.x Oct 7, 2024
15 checks passed
@pchila pchila deleted the mergify/bp/8.x/pr-5712 branch October 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants