Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep go.mod toolchain version in sync with .go-version contents #4636

Merged
merged 1 commit into from
May 2, 2024
Merged

Keep go.mod toolchain version in sync with .go-version contents #4636

merged 1 commit into from
May 2, 2024

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 29, 2024 •
edited
Loading

What does this PR do?

This PR updates the toolchain version, if specified, in the go.mod file with the contents of .go-version.

Why is it important?

To keep all Go version references in this repository the same.

See also: #4623 (comment)

@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements backport-v8.14.0 Automated backport with mergify labels Apr 29, 2024
@ycombinator ycombinator requested a review from a team as a code owner April 29, 2024 22:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator mentioned this pull request Apr 29, 2024
Closed
7 tasks
@ycombinator ycombinator requested review from michalpristas and removed request for nchaulet April 29, 2024 22:15
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator ycombinator merged commit 213c09e into elastic:main May 2, 2024
13 checks passed
@ycombinator ycombinator deleted the go-mod-toolchain-version branch May 2, 2024 13:05
mergify bot pushed a commit that referenced this pull request May 2, 2024
@ycombinator @mergify
Keep go.mod toolchain version in sync with .go-version contents (#4636)
a8134a8 
(cherry picked from commit 213c09e)
@mergify mergify bot mentioned this pull request May 2, 2024
Merged
ycombinator added a commit that referenced this pull request May 3, 2024
@mergify @ycombinator
Keep go.mod toolchain version in sync with .go-version contents (#4636)…
ff0c7fc 
… (#4656)

(cherry picked from commit 213c09e)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
v1v added a commit that referenced this pull request Aug 27, 2024
@v1v
cherry-pick #4636
4e1bfcd 
since it was not the one used
@v1v v1v mentioned this pull request Aug 28, 2024
Merged
7 tasks
@mergify mergify bot mentioned this pull request Sep 4, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@kaanyalti kaanyalti Awaiting requested review from kaanyalti kaanyalti was automatically assigned from elastic/elastic-agent-control-plane

Assignees

@ycombinator ycombinator

Labels
backport-v8.14.0 Automated backport with mergify chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @elasticmachine @michalpristas